linux-kernel - Re: [PATCH 1/2] gpio: gpio-pca953x.c: Correct type of reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpxmJV2XC+CK1SfJnH2YuaD2Gh=fiBQY+WPbjnqkvxGW6ZH_w@mail.gmail.com>
Date:   Wed, 28 Aug 2019 10:38:36 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     David Jander <david@...tonic.nl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: gpio-pca953x.c: Correct type of reg_direction

wt., 27 sie 2019 o 08:46 David Jander <david@...tonic.nl> napisał(a):
>
> The type of reg_direction needs to match the type of the regmap, which is
> u8.
>
> Signed-off-by: David Jander <david@...tonic.nl>
> ---
>  drivers/gpio/gpio-pca953x.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 378b206d2dc9..30072a570bc2 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -604,7 +604,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d)
>         u8 new_irqs;
>         int level, i;
>         u8 invert_irq_mask[MAX_BANK];
> -       int reg_direction[MAX_BANK];
> +       u8 reg_direction[MAX_BANK];
>
>         regmap_bulk_read(chip->regmap, chip->regs->direction, reg_direction,
>                          NBANK(chip));
> @@ -679,7 +679,7 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, u8 *pending)
>         bool pending_seen = false;
>         bool trigger_seen = false;
>         u8 trigger[MAX_BANK];
> -       int reg_direction[MAX_BANK];
> +       u8 reg_direction[MAX_BANK];
>         int ret, i;
>
>         if (chip->driver_data & PCA_PCAL) {
> @@ -768,7 +768,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
>  {
>         struct i2c_client *client = chip->client;
>         struct irq_chip *irq_chip = &chip->irq_chip;
> -       int reg_direction[MAX_BANK];
> +       u8 reg_direction[MAX_BANK];
>         int ret, i;
>
>         if (!client->irq)
> --
> 2.19.1
>

Applied for v5.4.

Thanks!
Bart