linux-kernel - Re: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Aug 2019 18:01:53 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     Niklas Söderlund 
        <niklas.soderlund@...natech.se>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Eduardo Valentin <edubezval@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        linux-pm@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: rcar_gen3_thermal: Use
 devm_add_action_or_reset() helper

On Wed, 2019-07-31 at 20:44 +0200, Niklas Söderlund wrote:
> Hi Geert,
> 
> Thanks for your work.
> 
> On 2019-07-31 14:50:53 +0200, Geert Uytterhoeven wrote:
> > Use the devm_add_action_or_reset() helper instead of open-coding
> > the
> > same operations.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> 
Hi, Geert,

https://patchwork.kernel.org/patch/11034969/ is the same fix submitted
a few days earlier, so I will take that patch instead. Thanks for the
patch anyway.

thanks,
rui

> > ---
> >  drivers/thermal/rcar_gen3_thermal.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/thermal/rcar_gen3_thermal.c
> > b/drivers/thermal/rcar_gen3_thermal.c
> > index a56463308694e937..2db7e7f8baf939fd 100644
> > --- a/drivers/thermal/rcar_gen3_thermal.c
> > +++ b/drivers/thermal/rcar_gen3_thermal.c
> > @@ -443,11 +443,10 @@ static int rcar_gen3_thermal_probe(struct
> > platform_device *pdev)
> >  		if (ret)
> >  			goto error_unregister;
> >  
> > -		ret = devm_add_action(dev, rcar_gen3_hwmon_action,
> > zone);
> > -		if (ret) {
> > -			rcar_gen3_hwmon_action(zone);
> > +		ret = devm_add_action_or_reset(dev,
> > rcar_gen3_hwmon_action,
> > +					       zone);
> > +		if (ret)
> >  			goto error_unregister;
> > -		}
> >  
> >  		ret = of_thermal_get_ntrips(tsc->zone);
> >  		if (ret < 0)
> > -- 
> > 2.17.1
> > 
> 
>