linux-kernel - Re: [PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1566987800.26704.0@gmail.com>
Date:   Wed, 28 Aug 2019 12:23:19 +0200
From:   Krzysztof Wilczynski <kswilczynski@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH] PCI: Move static keyword to the front of declarations in
 pci-bridge-emul.c

Hello Bjorn and Thomas,

Thank you for the feedback.

[...]
>>  Move the static keyword to the front of declarations of
>>  pci_regs_behavior and pcie_cap_regs_behavior, and resolve
>>  compiler warning that can be seen when building with
>>  warnings enabled (W=1).
> 
> It would be useful to include the compiler warning in the commit log.

Good point.  Sorry about that.  I will send a v2 that includes
updated commit message.

> I notice there are a few similar occurrences elsewhere in the tree:
> 
>   arch/csky/kernel/perf_event.c:const static struct of_device_id 
> csky_pmu_of_device_ids[] = {
>   arch/nds32/kernel/perf_event_cpu.c:const static struct of_device_id 
> cpu_pmu_of_device_ids[] = {
>   drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct 
> msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
>   drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct 
> msm_dsi_host_cfg_ops msm_dsi_6g_host_ops = {
>   drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct 
> msm_dsi_host_cfg_ops msm_dsi_6g_v2_host_ops = {
>   drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:const static 
> struct wiphy_iftype_ext_capab he_iftypes_ext_capa[] = {
>   fs/unicode/utf8-selftest.c:const static struct {
>   fs/unicode/utf8-selftest.c:const static struct {
> 
> Those should probably be fixed, too (but in separate patches since
> other maintainers would take them).

I will take care about these too.

Krzysztof