linux-kernel - Re: [PATCH v2] kunit: fix failure to build without printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190828115048.b4per6j3rw53oc5u@pathway.suse.cz>
Date:   Wed, 28 Aug 2019 13:50:48 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        frowand.list@...il.com, sergey.senozhatsky@...il.com,
        rostedt@...dmis.org, kunit-dev@...glegroups.com,
        Randy Dunlap <rdunlap@...radead.org>, sboyd@...nel.org,
        shuah@...nel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2] kunit: fix failure to build without printk

On Wed 2019-08-28 18:49:29, Sergey Senozhatsky wrote:
> On (08/28/19 02:31), Brendan Higgins wrote:
> [..]
> > Previously KUnit assumed that printk would always be present, which is
> > not a valid assumption to make. Fix that by removing call to
> > vprintk_emit, and calling printk directly.
> > 
> > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t
> > Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>
> 
> [..]
> 
> > -static void kunit_vprintk(const struct kunit *test,
> > -			  const char *level,
> > -			  struct va_format *vaf)
> > -{
> > -	kunit_printk_emit(level[1] - '0', "\t# %s: %pV", test->name, vaf);
> > -}
> 
> This patch looks good to me. I like the removal of recursive
> vsprintf() (%pV).

Same here. And I am happy that we did not add more external
vprintk_emit() callers. It would be great to rework dev_printk()
as well.

Best Regards,
Petr