linux-kernel - Re: [PATCH] arm/arm64: defconfig: Update configs to use the new CROS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3zYpgouGAibyMjDykZmy+ABnx6AD2cYpHnXq9Zsw2V=w@mail.gmail.com>
Date:   Wed, 28 Aug 2019 14:09:10 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        SoC Team <soc@...nel.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Collabora kernel ML <kernel@...labora.com>,
        Lee Jones <lee.jones@...aro.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@...r.kernel.org>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Leonard Crestez <leonard.crestez@....com>,
        "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
        <linux-samsung-soc@...r.kernel.org>,
        Olof Johansson <olof@...om.net>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Kukjin Kim <kgene@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Fabrice Gasnier <fabrice.gasnier@...com>,
        Daniel Mack <daniel@...que.org>,
        Russell King <linux@...linux.org.uk>,
        Shawn Guo <shawnguo@...nel.org>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        "Yannick Fertr?" <yannick.fertre@...com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Tony Lindgren <tony@...mide.com>,
        Anson Huang <Anson.Huang@....com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH] arm/arm64: defconfig: Update configs to use the new
 CROS_EC options

On Wed, Aug 28, 2019 at 12:10 PM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
> On 27/8/19 18:12, Arnd Bergmann wrote:
> > On Tue, Aug 27, 2019 at 6:08 PM Bjorn Andersson
> > <bjorn.andersson@...aro.org> wrote:
> >>
> >> On Tue 27 Aug 08:48 PDT 2019, Enric Balletbo i Serra wrote:
> >>
> >>> Recently we refactored the CrOS EC drivers moving part of the code from
> >>> the MFD subsystem to the platform chrome subsystem. During this change
> >>> we needed to rename some config options, so, update the defconfigs
> >>> accordingly.
> >>>
> >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> >>> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> >>> Reviewed-by: Gwendal Grignou <gwendal@...omium.org>
> >>> Tested-by: Gwendal Grignou <gwendal@...omium.org>
> >>
> >> Can we make the entries in the generic arm64 defconfig modules?
> >
> > Good idea.
> >
> > Actually I would prefer to have all of them as modules for consistency,
> > if at all possible.
> >
>
> It is very common boot Chromebooks from an USB device, the EC needs to be
> built-in in order to boot from these devices, otherwise you should use an
> initramfs. I'd like to avoid forcing people to build an initramfs just to boot
> from these devices if possible, in fact, my usual workflow is without initramfs,
> and knowing that with the default defconfig just should boot helps a lot sometimes.
>
> Note that, it's not the case for EC subdevices, these are already build as modules.

Ok, fair enough, let's leave it built-in then.

> BTW, Lee asked if this patch should be squashed with the patches that really
> renames the config options to help bisect ability, I don't have a hard opinion
> as I don't usually run the config option between bisection steps, so please let
> me know what do you prefer and I'll respin the patches ASAP if that's the case.

I'm not usually worried about bisection in defconfig changes, since like you
say most commonly one would not run 'make defconfig' betweens the
bisection steps.

If we really care about it, we could keep a symbol like this
in drivers/platform/chrome/Kconfig for one release:

config CONFIG_MFD_CROS_EC
        tristate "Enable ChromeOS Embedded Controller"
        select CROS_EC
        select CHROME_PLATFORMS
        select CONFIG_MFD_CROS_EC_DEV
        help
           This is a transitional Kconfig option and will be removed
           after everyone enables the parts individually.

      Arnd