linux-kernel - Re: [PATCHv5] drivers/amba: add reset control to amba bus probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <292438.1567000005@turing-police>
Date:   Wed, 28 Aug 2019 09:46:45 -0400
From:   "Valdis Klētnieks" <valdis.kletnieks@...edu>
To:     Dinh Nguyen <dinguyen@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        robh@...nel.org, linux@...linux.org.uk, frowand.list@...il.com,
        keescook@...omium.org, anton@...msg.org, ccross@...roid.com,
        tony.luck@...el.com, daniel.thompson@...aro.org,
        linus.walleij@...aro.org, manivannan.sadhasivam@...aro.org,
        linux-arm-kernel@...ts.infradead.org, p.zabel@...gutronix.de
Subject: Re: [PATCHv5] drivers/amba: add reset control to amba bus probe

On Wed, 28 Aug 2019 08:34:20 -0500, Dinh Nguyen said:

> > Does this DTRT for both old and new U-Boots? My naive reading of
> > this patch
>
> What is a DTRT?

Do The Right Thing, sorry...

> > says on an old U-Boot, we end up attempting to bring it out of
> > reset even though they had already been brought out.
> >
>
> If the peripheral is already out of reset, de-asserting the reset has
> no affect.

OK, thanks.  There's been hardware where doing that sort of thing twice will
confuse the device and cause issues.

Content of type "application/pgp-signature" skipped