linux-kernel - Re: [PATCH v2 00/14] treewide: prefer __section from compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8851ba7888c433dac2ffa5d80f3289cd05940a3.camel@perches.com>
Date:   Tue, 27 Aug 2019 19:47:51 -0700
From:   Joe Perches <joe@...ches.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        miguel.ojeda.sandonis@...il.com
Cc:     sedat.dilek@...il.com, will@...nel.org, jpoimboe@...hat.com,
        naveen.n.rao@...ux.vnet.ibm.com, davem@...emloft.net,
        paul.burton@...s.com, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 00/14] treewide: prefer __section from
 compiler_attributes.h

On Tue, 2019-08-27 at 13:39 -0700, Nick Desaulniers wrote:
> GCC unescapes escaped string section names while Clang does not. Because
> __section uses the `#` stringification operator for the section name, it
> doesn't need to be escaped.
> 
> This fixes an Oops observed in distro's that use systemd and not
> net.core.bpf_jit_enable=1, when their kernels are compiled with Clang.
> 
> Instead, we should:
> 1. Prefer __section(.section_name_no_quotes).
> 2. Only use __attribute__((__section(".section"))) when creating the

Please use __ before and after section

i.e. __attribute__((__section__("<section_name>")))