linux-kernel - Re: [PATCH] drm/komeda: Add ACLK rate to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190828141508.GA6738@jamwan02-TSP300>
Date:   Wed, 28 Aug 2019 14:15:15 +0000
From:   "james qian wang (Arm Technology China)" <james.qian.wang@....com>
To:     Mihail Atanassov <Mihail.Atanassov@....com>
CC:     nd <nd@....com>, Liviu Dudau <Liviu.Dudau@....com>,
        Brian Starkey <Brian.Starkey@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/komeda: Add ACLK rate to sysfs

Hi Mihail:

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@....com>

James.

On Wed, Aug 28, 2019 at 11:03:49AM +0000, Mihail Atanassov wrote:
> Expose node with the name 'aclk_hz'
> 
> Signed-off-by: Mihail Atanassov <mihail.atanassov@....com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 0142ee991957..e8d67395a3b9 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -91,9 +91,19 @@ config_id_show(struct device *dev, struct device_attribute *attr, char *buf)
>  }
>  static DEVICE_ATTR_RO(config_id);
>  
> +static ssize_t
> +aclk_hz_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct komeda_dev *mdev = dev_to_mdev(dev);
> +
> +	return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
> +}
> +static DEVICE_ATTR_RO(aclk_hz);
> +
>  static struct attribute *komeda_sysfs_entries[] = {
>  	&dev_attr_core_id.attr,
>  	&dev_attr_config_id.attr,
> +	&dev_attr_aclk_hz.attr,
>  	NULL,
>  };
>  
> -- 
> 2.22.0