linux-kernel - Re: [PATCH 4.9 033/223] perf test 6: Fix missing kvm module load for s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190828030216.GX5281@sasha-vm>
Date:   Tue, 27 Aug 2019 23:02:16 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 4.9 033/223] perf test 6: Fix missing kvm module load for
 s390

On Wed, Aug 28, 2019 at 01:12:44AM +0100, Ben Hutchings wrote:
>On Fri, 2019-08-02 at 11:34 +0200, Greg Kroah-Hartman wrote:
>> [ Upstream commit 53fe307dfd309e425b171f6272d64296a54f4dff ]
>
>This results in numerous compiler errors:
>
>tests/parse-events.c: In function 'kvm_s390_create_vm_valid':
>tests/parse-events.c:25:14: error: implicit declaration of function 'get_events_file' [-Werror=implicit-function-declaration]
>  eventfile = get_events_file("kvm-s390");
>              ^~~~~~~~~~~~~~~
>tests/parse-events.c:25:12: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>  eventfile = get_events_file("kvm-s390");
>            ^
>tests/parse-events.c:34:3: error: implicit declaration of function 'put_events_file' [-Werror=implicit-function-declaration]
>   put_events_file(eventfile);
>   ^~~~~~~~~~~~~~~
>tests/parse-events.c: At top level:
>tests/parse-events.c:1622:3: error: unknown field 'valid' specified in initializer
>   .valid = kvm_s390_create_vm_valid,
>   ^
>tests/parse-events.c:1622:12: error: excess elements in struct initializer [-Werror]
>   .valid = kvm_s390_create_vm_valid,
>            ^~~~~~~~~~~~~~~~~~~~~~~~
>tests/parse-events.c:1622:12: note: (near initialization for 'test__events[45]')
>
>It is using functions that were only added in Linux 4.18 so I think it
>should be reverted from the 4.4, 4.9, and 4.14 stable branches.

Sigh... I didn't think of adding cross compilation to the tools dir...

Thanks for this, now reverted for those branches.

--
Thanks,
Sasha