linux-kernel - Re: linux-next: Tree for Aug 27 (objtool)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f354f4be-99c7-346f-c7c5-ac5ce8a72a16@infradead.org>
Date:   Wed, 28 Aug 2019 09:05:18 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: linux-next: Tree for Aug 27 (objtool)

On 8/28/19 8:51 AM, Josh Poimboeuf wrote:
> On Tue, Aug 27, 2019 at 12:05:42PM -0700, Randy Dunlap wrote:
>> On 8/27/19 8:59 AM, Josh Poimboeuf wrote:
>>> On Tue, Aug 27, 2019 at 08:40:07AM -0700, Randy Dunlap wrote:
>>>> On 8/27/19 2:05 AM, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>>
>>>>> Changes since 20190826:
>>>>>
>>>>
>>>> on x86_64:
>>>>
>>>> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x33: unreachable instruction
>>>>
>>>>> gcc --version
>>>> gcc (SUSE Linux) 7.4.0
>>>>
>>>>
>>>> want more info?
>>>
>>> Yes, can you provide the .o and the .config?
>>>
>>
>> Sure.  The .o was 508KB, so I compressed it.
> 
> Thanks Randy.  Here's a tentative fix.  I need to make sure it doesn't
> break anything else.

Works for me on the reported failure.  Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>


> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 176f2f084060..35a40d610474 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -556,7 +556,7 @@ static int add_jump_destinations(struct objtool_file *file)
>  		    insn->type != INSN_JUMP_UNCONDITIONAL)
>  			continue;
>  
> -		if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
> +		if (insn->offset == FAKE_JUMP_OFFSET)
>  			continue;
>  
>  		rela = find_rela_by_dest_range(insn->sec, insn->offset,
> 


-- 
~Randy