[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190829155127.GA136563@architecture4>
Date: Thu, 29 Aug 2019 23:51:27 +0800
From: Gao Xiang <gaoxiang25@...wei.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: <devel@...verdev.osuosl.org>,
Sasha Levin <alexander.levin@...rosoft.com>,
Valdis Klētnieks <valdis.kletnieks@...edu>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
<linux-kernel@...r.kernel.org>,
"Christoph Hellwig" <hch@...radead.org>,
<linux-fsdevel@...r.kernel.org>,
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging
Hi Dan,
On Thu, Aug 29, 2019 at 06:43:46PM +0300, Dan Carpenter wrote:
> > p.s. There are 2947 (un)likely places in fs/ directory.
>
> I was complaining about you adding new pointless ones, not existing
> ones. The likely/unlikely annotations are supposed to be functional and
> not decorative. I explained this very clearly.
I don't think that is mostly pointless. I think it has functional use
because all error handling paths are rarely happened, or can you remove
the unlikely in IS_ERR as well?
>
> Probably most of the annotations in fs/ are wrong but they are also
> harmless except for the slight messiness. However there are definitely
> some which are important so removing them all isn't a good idea.
>
> > If you like, I will delete them all.
>
> But for erofs, I don't think that any of the likely/unlikely calls have
> been thought about so I'm fine with removing all of them in one go.
Maybe some misuse but rare, I will show you case by case. Wait a minute.
Thanks,
Gao Xiang
>
> regards,
> dan carpenter
>
Powered by blists - more mailing lists