linux-kernel - Re: [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <263584eb-0e74-d8a4-613c-14877a42f155@linux.ibm.com>
Date:   Thu, 29 Aug 2019 10:50:52 +0530
From:   Hari Bathini <hbathini@...ux.ibm.com>
To:     Michal Suchánek <msuchanek@...e.de>
Cc:     linuxppc-dev@...ts.ozlabs.org, Yangtao Li <tiny.windzz@...il.com>,
        Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH rebased] powerpc/fadump: when fadump is supported register
 the fadump sysfs files.



On 28/08/19 10:37 PM, Michal Suchánek wrote:
> On Tue, 27 Aug 2019 17:57:31 +0530
> Hari Bathini <hbathini@...ux.ibm.com> wrote:
> 

[...]

>> Also, get rid of the error message when fadump is
>> not supported as it is already taken care of in fadump_reserve_mem() function.
> 
> That should not be called in that case, should it?

fadump_reserve_mem() is called during early boot while this is an initcall that happens
later. Not sure if we can make the initcall conditional on fadump support though..

> Anyway, I find the message right next to the message about reserving
> memory for kdump. So it really looks helpful in the log.

The message you see right after memory reservation for kdump is coming from
fadump_reserve_mem() function. This is the repeat of the same message logged
much later...
 
- Hari