linux-kernel - Re: [PATCH] mm/z3fold.c: fix lock/unlock imbalance in z3fold_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <051d8e3b-b705-d34b-3193-550bef3b5c65@embeddedor.com>
Date:   Thu, 29 Aug 2019 14:14:40 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Henry Burns <henryburns@...gle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/z3fold.c: fix lock/unlock imbalance in
 z3fold_page_isolate



On 8/26/19 6:05 PM, Andrew Morton wrote:
> 
> 
> This is a bit silly:
> 
> 			if (..) {
> 				...
> 				z3fold_page_unlock(zhdr);
> 				return false;
> 			}
> 			z3fold_page_unlock(zhdr);
> 			return false;
> 
> but presumably the compiler will clean up after us.
> 

I agree. I just sent a patch for that:

https://lore.kernel.org/lkml/20190829191312.GA20298@embeddedor/

Thanks
--
Gustavo