linux-kernel - Re: [PATCH] rpmsg: glink: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09987035-9768-f6dd-c668-5b04caf61e31@embeddedor.com>
Date:   Thu, 29 Aug 2019 14:15:42 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Ohad Ben-Cohen <ohad@...ery.com>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rpmsg: glink: Use struct_size() helper



On 8/29/19 2:09 PM, Bjorn Andersson wrote:
> On Thu 29 Aug 11:17 PDT 2019, Gustavo A. R. Silva wrote:
> 
>> One of the more common cases of allocation size calculations is finding
>> the size of a structure that has a zero-sized array at the end, along
>> with memory for some number of elements for that array. For example:
>>
>> struct {
>> 	...
>> 	struct intent_pair intents[];
>> } __packed * msg;
>>
>> Make use of the struct_size() helper instead of an open-coded version
>> in order to avoid any potential type mistakes.
>>
>> So, replace the following form:
>>
>> sizeof(*msg) + sizeof(struct intent_pair) * count
>>
>> with:
>>
>> struct_size(msg, intents, count)
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Applied, thanks!
> 

Awesome. :)

Thanks!
--
Gustavo