linux-kernel - Re: [PATCH v2] um: Rewrite host RNG driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Aug 2019 23:03:27 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     Dark <dark@...atile.bz>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-um <linux-um@...ts.infradead.org>,
        Richard Weinberger <richard.weinberger@...il.com>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH v2] um: Rewrite host RNG driver.

----- Ursprüngliche Mail -----
>> ----- Ursprüngliche Mail -----
>> > Von: "Dark" <dark@...atile.bz>
>> > +	// Returning -EAGAIN to userspace is not nice.
>> > +	if (err == -EAGAIN)
>> > +		return 0;
>> 
>> Hmm, doesn't this result in a short read?
>> The current drives sets the calling task to sleep and wakes
>> it up as soon data is available again. I'd assumes ti have the
>> same behavior for the new driver.
>> 
>> Thanks,
>> //richard
> 
> Clearly this patch needs a lot more work before I submit it. I'll
> take some time to polish it up and then resubmit it if that's fine.

No need to worry, take your time. Thanks a lot for working on this driver!

Thanks,
//richard