linux-kernel - Re: [RFC v1 1/9] KVM: x86: Add base address parameter for get_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190829211015.GU5447@tassilo.jf.intel.com>
Date:   Thu, 29 Aug 2019 14:10:15 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Luwei Kang <luwei.kang@...el.com>
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC v1 1/9] KVM: x86: Add base address parameter for
 get_fixed_pmc function

>  /* returns fixed PMC with the specified MSR */
> -static inline struct kvm_pmc *get_fixed_pmc(struct kvm_pmu *pmu, u32 msr)
> +static inline struct kvm_pmc *get_fixed_pmc(struct kvm_pmu *pmu, u32 msr,
> +								int base)

Better define a __get_fixed_pmc just for this case, with the existing
get_fixed_pmc being a wrapper.

This would avoid changing all the callers below.


-Andi