linux-kernel - Re: [PATCH 1/3] scsi: cxlflash: Fix fallthrough warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <814EA905-2AD8-4451-AC1E-4439B64227E7@linux.ibm.com>
Date:   Thu, 29 Aug 2019 16:30:43 -0500
From:   Uma Krishnan <ukrishn@...ux.ibm.com>
To:     Michal Suchanek <msuchanek@...e.de>
Cc:     linuxppc-dev@...ts.ozlabs.org,
        "Manoj N. Kumar" <manoj@...ux.ibm.com>,
        "Matthew R. Ochs" <mrochs@...ux.ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] scsi: cxlflash: Fix fallthrough warnings.

Below commit queued up for 5.4 includes these changes.

commit 657bd277c162580674ddb86a90c4aeb62639bff5
Author: Gustavo A. R. Silva <gustavo@...eddedor.com>
Date:   Sun Jul 28 19:21:19 2019 -0500

Thanks,
Uma Krishnan

> On Aug 29, 2019, at 7:32 AM, Michal Suchanek <msuchanek@...e.de> wrote:
> 
> Add fallthrough comments where missing.
> 
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
> drivers/scsi/cxlflash/main.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
> index b1f4724efde2..f402fa9a7bec 100644
> --- a/drivers/scsi/cxlflash/main.c
> +++ b/drivers/scsi/cxlflash/main.c
> @@ -753,10 +753,13 @@ static void term_intr(struct cxlflash_cfg *cfg, enum undo_level level,
> 		/* SISL_MSI_ASYNC_ERROR is setup only for the primary HWQ */
> 		if (index == PRIMARY_HWQ)
> 			cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 3, hwq);
> +		/* fall through */
> 	case UNMAP_TWO:
> 		cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 2, hwq);
> +		/* fall through */
> 	case UNMAP_ONE:
> 		cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 1, hwq);
> +		/* fall through */
> 	case FREE_IRQ:
> 		cfg->ops->free_afu_irqs(hwq->ctx_cookie);
> 		/* fall through */
> @@ -973,14 +976,18 @@ static void cxlflash_remove(struct pci_dev *pdev)
> 	switch (cfg->init_state) {
> 	case INIT_STATE_CDEV:
> 		cxlflash_release_chrdev(cfg);
> +		/* fall through */
> 	case INIT_STATE_SCSI:
> 		cxlflash_term_local_luns(cfg);
> 		scsi_remove_host(cfg->host);
> +		/* fall through */
> 	case INIT_STATE_AFU:
> 		term_afu(cfg);
> +		/* fall through */
> 	case INIT_STATE_PCI:
> 		cfg->ops->destroy_afu(cfg->afu_cookie);
> 		pci_disable_device(pdev);
> +		/* fall through */
> 	case INIT_STATE_NONE:
> 		free_mem(cfg);
> 		scsi_host_put(cfg->host);
> @@ -3017,6 +3024,7 @@ static ssize_t num_hwqs_store(struct device *dev,
> 		wait_event(cfg->reset_waitq, cfg->state != STATE_RESET);
> 		if (cfg->state == STATE_NORMAL)
> 			goto retry;
> +		/* fall through */
> 	default:
> 		/* Ideally should not happen */
> 		dev_err(dev, "%s: Device is not ready, state=%d\n",
> -- 
> 2.12.3
>