linux-kernel - Re: [tip: timers/core] itimers: Use quick sample function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201908300744.vEL0XoT5%lkp@intel.com>
Date:   Fri, 30 Aug 2019 07:47:35 +0800
From:   kbuild test robot <lkp@...el.com>
To:     tip-bot2 for Thomas Gleixner <tip-bot2@...utronix.de>
Cc:     kbuild-all@...org, linux-tip-commits@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Frederic Weisbecker <frederic@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [tip: timers/core] itimers: Use quick sample function

Hi tip-bot2,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190829]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/tip-bot2-for-Thomas-Gleixner/itimers-Use-quick-sample-function/20190830-063115
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/time/itimer.c: In function 'get_cpu_itimer':
>> kernel/time/itimer.c:61:3: error: implicit declaration of function 'thread_group_sample_cputime'; did you mean 'thread_group_cputime'? [-Werror=implicit-function-declaration]
      thread_group_sample_cputime(tsk, &cputime);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      thread_group_cputime
   cc1: some warnings being treated as errors

vim +61 kernel/time/itimer.c

    46	
    47	static void get_cpu_itimer(struct task_struct *tsk, unsigned int clock_id,
    48				   struct itimerval *const value)
    49	{
    50		u64 val, interval;
    51		struct cpu_itimer *it = &tsk->signal->it[clock_id];
    52	
    53		spin_lock_irq(&tsk->sighand->siglock);
    54	
    55		val = it->expires;
    56		interval = it->incr;
    57		if (val) {
    58			struct task_cputime cputime;
    59			u64 t;
    60	
  > 61			thread_group_sample_cputime(tsk, &cputime);
    62			if (clock_id == CPUCLOCK_PROF)
    63				t = cputime.utime + cputime.stime;
    64			else
    65				/* CPUCLOCK_VIRT */
    66				t = cputime.utime;
    67	
    68			if (val < t)
    69				/* about to fire */
    70				val = TICK_NSEC;
    71			else
    72				val -= t;
    73		}
    74	
    75		spin_unlock_irq(&tsk->sighand->siglock);
    76	
    77		value->it_value = ns_to_timeval(val);
    78		value->it_interval = ns_to_timeval(interval);
    79	}
    80	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28074 bytes)