linux-kernel - [PATCH 0/2] mtd: mtdcore: add debugfs nodes for querying the flash name and id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Aug 2019 07:10:28 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <richard@....at>, <miquel.raynal@...tlin.com>, <vigneshr@...com>,
        <boris.brezillon@...labora.com>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <zhuohao@...omium.org>
CC:     <Tudor.Ambarus@...rochip.com>
Subject: [PATCH 0/2] mtd: mtdcore: add debugfs nodes for querying the flash
 name and id

From: Tudor Ambarus <tudor.ambarus@...rochip.com>

I just rebased Zhuohao's patches and fixed some checkpatch warnings and
checks. I'll let this a little bit here for some short review, and I intend
to apply the patches later today.

For patch 1/, I fixed the following:
CHECK: multiple assignments should be avoided
#82: FILE: drivers/mtd/mtdcore.c:390:
+	root = mtd->dbg.dfs_dir = debugfs_create_dir(dev_name(dev),

WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
#90: FILE: drivers/mtd/mtdcore.c:398:
+		dent = debugfs_create_file("partid", S_IRUSR, root, mtd,

WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
#97: FILE: drivers/mtd/mtdcore.c:405:
+		dent = debugfs_create_file("partname", S_IRUSR, root, mtd,


For patch 2/, I fixed some alignment checks, and I moved the call to
spi_nor_debugfs_init() immediately after spi_nor_get_flash_info(),
because it uses some info data set there.
CHECK: Alignment should match open parenthesis
#162: FILE: drivers/mtd/spi-nor/spi-nor.c:3939:
+static void spi_nor_debugfs_init(struct spi_nor *nor,
+		const struct flash_info *info)

CHECK: Alignment should match open parenthesis
#168: FILE: drivers/mtd/spi-nor/spi-nor.c:3945:
+	mtd->dbg.partid = devm_kasprintf(nor->dev, GFP_KERNEL,
+					"spi-nor:%*phN",

Zhuohao Lee (2):
  mtd: mtdcore: add debugfs nodes for querying the flash name and id
  mtd: spi-nor: enable the debugfs for the partname and partid

 drivers/mtd/mtdcore.c         | 86 ++++++++++++++++++++++++++++++++++++++-----
 drivers/mtd/spi-nor/spi-nor.c | 12 ++++++
 include/linux/mtd/mtd.h       |  3 ++
 3 files changed, 92 insertions(+), 9 deletions(-)

-- 
2.9.5