linux-kernel - Re: [PATCH 1/4] fs: always build llseek.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190829120657.400ee915@naga>
Date:   Thu, 29 Aug 2019 12:06:57 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     David Hildenbrand <david@...hat.com>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        Max Filippov <jcmvbkbc@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        Breno Leitao <leitao@...ian.org>,
        Michael Neuling <mikey@...ling.org>,
        Firoz Khan <firoz.khan@...aro.org>,
        Allison Randal <allison@...utok.net>,
        Joel Stanley <joel@....id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Hari Bathini <hbathini@...ux.ibm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrew Donnellan <andrew.donnellan@....ibm.com>,
        linux-fsdevel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linuxppc-dev@...ts.ozlabs.org,
        Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 1/4] fs: always build llseek.

On Wed, 28 Aug 2019 23:22:00 -0700
Christoph Hellwig <hch@...radead.org> wrote:

> On Wed, Aug 28, 2019 at 06:15:40PM +0200, Michal Suchánek wrote:
> > On Wed, 28 Aug 2019 08:15:52 -0700
> > Christoph Hellwig <hch@...radead.org> wrote:
> >   
> > > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote:  
> > > > 64bit !COMPAT does not build because the llseek syscall is in the tables.    
> > > 
> > > Well, this will bloat thinkgs like 64-bit RISC-V for no good reason.
> > > Please introduce a WANT_LSEEK like symbol that ppc64 can select instead.  
> > 
> > It also builds when llseek is marked as 32bit only in syscall.tbl
> > 
> > It seems it was handled specially in some way before syscall.tbl was
> > added, though (removed in ab66dcc76d6ab8fae9d69d149ae38c42605e7fc5)  
> 
> Independ of if you need it on a purely 64-bit build on powerpc (which
> I'll let the experts figure out) it is not needed on a purely 64-bit
> build on other platforms.  So please make sure it is still built
> conditional, just possibly with an opt-in for powerpc.

AFAICT it is needed for all 64bit platforms with unified syscall.tbl.

I modified the syscall.tbl for powerpc to not need the syscall with
64bit only build but other platforms are still broken. There are a few
platforms that use multiple tables and on those the 64bit one indeed
does not contain llseek.

Thanks

Michal