linux-kernel - Re: [tip: timers/core] posix-cpu-timers: Use common permission check in posix_cpu_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Aug 2019 19:00:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     tip-bot2 for Thomas Gleixner <tip-bot2@...utronix.de>
Cc:     kbuild-all@...org, linux-tip-commits@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Frederic Weisbecker <frederic@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [tip: timers/core] posix-cpu-timers: Use common permission check
 in posix_cpu_clock_get()

Hi tip-bot2,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190828]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/tip-bot2-for-Thomas-Gleixner/posix-cpu-timers-Use-common-permission-check-in-posix_cpu_clock_get/20190829-181227
config: parisc-c3000_defconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   kernel/time/posix-cpu-timers.c: In function 'posix_cpu_clock_get':
>> kernel/time/posix-cpu-timers.c:275:8: error: implicit declaration of function 'get_task_for_clock'; did you mean 'get_task_struct'? [-Werror=implicit-function-declaration]
     tsk = get_task_for_clock(clock);
           ^~~~~~~~~~~~~~~~~~
           get_task_struct
>> kernel/time/posix-cpu-timers.c:275:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     tsk = get_task_for_clock(clock);
         ^
   cc1: some warnings being treated as errors

vim +275 kernel/time/posix-cpu-timers.c

   268	
   269	static int posix_cpu_clock_get(const clockid_t clock, struct timespec64 *tp)
   270	{
   271		const clockid_t clkid = CPUCLOCK_WHICH(clock);
   272		struct task_struct *tsk;
   273		u64 t;
   274	
 > 275		tsk = get_task_for_clock(clock);
   276		if (!tsk)
   277			return -EINVAL;
   278	
   279		if (CPUCLOCK_PERTHREAD(clock))
   280			cpu_clock_sample(clkid, tsk, &t);
   281		else
   282			cpu_clock_sample_group(clkid, tsk, &t);
   283		put_task_struct(tsk);
   284	
   285		*tp = ns_to_timespec64(t);
   286		return 0;
   287	}
   288	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (15667 bytes)