linux-kernel - Re: [PATCH v2] firmware: google: update vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Aug 2019 13:24:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hung-Te Lin <hungte@...omium.org>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Allison Randal <allison@...utok.net>,
        Colin Ian King <colin.king@...onical.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Julius Werner <jwerner@...omium.org>,
        Alexios Zavras <alexios.zavras@...el.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] firmware: google: update vpd_decode from upstream

On Thu, Aug 29, 2019 at 06:19:45PM +0800, Hung-Te Lin wrote:
> The VPD implementation from Chromium Vital Product Data project used to
> parse data from untrusted input without checking if there is invalid
> data (for example the if the size becomes negative, or larger than whole
> input buffer), which may cause buffer overflow on corrupted data.
> 
> To fix that, the upstream driver 'vpd_decode' has changed size
> parameters to unsigned integer (u32), and refactored the parsing of
> entry header so the size is always checked properly.

"the upstream driver"?  That's the code you are touching here.

What do you mean by "upstream"?  Your subject and this paragraph does
not make much sense.

Please describe exactly what you are doing here, we don't care what
anyone else did with this code in any random repo that is not Linus's
tree.

thanks,

greg k-h