[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190830.135535.690331861133879813.davem@davemloft.net>
Date: Fri, 30 Aug 2019 13:55:35 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: tbogendoerfer@...e.de
Cc: ralf@...ux-mips.org, paul.burton@...s.com, jhogan@...nel.org,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 00/15] ioc3-eth improvements
From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
Date: Fri, 30 Aug 2019 11:25:23 +0200
> In my patch series for splitting out the serial code from ioc3-eth
> by using a MFD device there was one big patch for ioc3-eth.c,
> which wasn't really usefull for reviews. This series contains the
> ioc3-eth changes splitted in smaller steps and few more cleanups.
> Only the conversion to MFD will be done later in a different series.
>
> Changes in v3:
> - no need to check skb == NULL before passing it to dev_kfree_skb_any
> - free memory allocated with get_page(s) with free_page(s)
> - allocate rx ring with just GFP_KERNEL
> - add required alignment for rings in comments
>
> Changes in v2:
> - use net_err_ratelimited for printing various ioc3 errors
> - added missing clearing of rx buf valid flags into ioc3_alloc_rings
> - use __func__ for printing out of memory messages
Series applied, thanks.
I might be nice to use get_order() instead of hardcoding the page size
when "2" is passed into the page alloc/free calls. Just FYI...
Powered by blists - more mailing lists