linux-kernel - Re: [PATCH v1] tracing: Drop static keyword for exported ftrace_set_clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190830170424.40c4188a@gandalf.local.home>
Date:   Fri, 30 Aug 2019 17:04:24 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Divya Indi <divya.indi@...cle.com>
Subject: Re: [PATCH v1] tracing: Drop static keyword for exported
 ftrace_set_clr_event()

On Fri, 30 Aug 2019 22:32:28 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> When we export something, it shan't be static.

I'm finally getting around to my patch queue (it's unfortunately much
bigger than I should be). But my punishment is duplicate patches.

Someone beat you to it...

 http://lkml.kernel.org/r/20190704172110.27041-1-efremov@linux.com

-- Steve

> 
> Fixes: f45d1225adb0 ("tracing: Kernel access to Ftrace instances")
> Cc: Divya Indi <divya.indi@...cle.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/linux/trace_events.h | 1 +
>  kernel/trace/trace_events.c  | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> index 5150436783e8..30a8cdcfd4a4 100644
> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -548,6 +548,7 @@ extern int trace_event_get_offsets(struct trace_event_call *call);
>  
>  #define is_signed_type(type)	(((type)(-1)) < (type)1)
>  
> +int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set);
>  int trace_set_clr_event(const char *system, const char *event, int set);
>  
>  /*
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 5a189fb8ec23..b89cdfe20bc1 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -787,7 +787,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match,
>  	return ret;
>  }
>  
> -static int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
> +int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
>  {
>  	char *event = NULL, *sub = NULL, *match;
>  	int ret;