linux-kernel - Re: [PATCH] mm/vmalloc: move 'area->pages' after if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190830053808.GM28313@dhcp22.suse.cz>
Date:   Fri, 30 Aug 2019 07:38:08 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     akpm@...ux-foundation.org, urezki@...il.com, guro@...com,
        rpenyaev@...e.de, rick.p.edgecombe@...el.com, rppt@...ux.ibm.com,
        aryabinin@...tuozzo.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmalloc: move 'area->pages' after if statement

On Fri 30-08-19 12:57:16, Austin Kim wrote:
> If !area->pages statement is true where memory allocation fails, 
> area is freed.
> 
> In this case 'area->pages = pages' should not executed.
> So move 'area->pages = pages' after if statement.
> 
> Signed-off-by: Austin Kim <austindh.kim@...il.com>

Acked-by: Michal Hocko <mhocko@...e.com>

Thanks!
> ---
>  mm/vmalloc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index b810103..af93ba6 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2416,13 +2416,15 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
>  	} else {
>  		pages = kmalloc_node(array_size, nested_gfp, node);
>  	}
> -	area->pages = pages;
> -	if (!area->pages) {
> +
> +	if (!pages) {
>  		remove_vm_area(area->addr);
>  		kfree(area);
>  		return NULL;
>  	}
>  
> +	area->pages = pages;
> +
>  	for (i = 0; i < area->nr_pages; i++) {
>  		struct page *page;
>  
> -- 
> 2.6.2
> 

-- 
Michal Hocko
SUSE Labs