linux-kernel - Re: [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Aug 2019 11:34:37 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        oneukum@...e.com, acho@...e.com, tiwai@...e.com, jlee@...e.com
Subject: Re: [PATCH] Revert "Bluetooth: btusb: driver to enable the
 usb-wakeup feature"

On Fri, 30 Aug 2019 09:49:35 +0200
Marcel Holtmann <marcel@...tmann.org> wrote:

> Hi Michal,
> 
> > This reverts commit a0085f2510e8976614ad8f766b209448b385492f.
> > 
> > After this commit systems wake up at random, most commonly when
> > 
> > - put to sleep while bluetooth audio stream is running
> > - connected bluetooth audio device is powered off while system is
> > asleep
> > 
> > This is broken since the commit was merged up to 5.3-rc6.
> > 
> > Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> > ---
> > drivers/bluetooth/btusb.c | 5 -----
> > 1 file changed, 5 deletions(-)  
> 
> I think that Mario send in the same patch already.

Yes, I found it after this copy was threaded with the previous one on
lore.kernel.org. Anyway, there are multiple reasons why this is broken.

AFAICT the wakeup feature is only workable with OSes that are able to
wakeup into a small gadget that can check if the packet is interesting
and put the system back to sleep if not without going through the whole
online/offline everything sequence.

Thanks

Michal