linux-kernel - Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190830120601.GC10981@hsiangkao-HP-ZHAN-66-Pro-G1>
Date:   Fri, 30 Aug 2019 20:06:05 +0800
From:   Gao Xiang <hsiangkao@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Gao Xiang <gaoxiang25@...wei.com>, devel@...verdev.osuosl.org,
        Chao Yu <chao@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Miao Xie <miaoxie@...wei.com>, Chao Yu <yuchao0@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>, weidu.du@...wei.com,
        Fang Wei <fangwei1@...wei.com>, Joe Perches <joe@...ches.com>,
        linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations

Hi Dan,

On Fri, Aug 30, 2019 at 02:30:47PM +0300, Dan Carpenter wrote:
> On Fri, Aug 30, 2019 at 11:36:42AM +0800, Gao Xiang wrote:
> > As Dan Carpenter suggested [1], I have to remove
> > all erofs likely/unlikely annotations.
> > 
> > [1] https://lore.kernel.org/linux-fsdevel/20190829154346.GK23584@kadam/
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> > ---
> 
> Thanks!
> 
> This is a nice readability improvement and I'm so sure it won't impact
> benchmarking at all.
> 
> Acked-by: Dan Carpenter <dan.carpenter@...cle.com>

It seems Greg merged another version... I have no idea but thanks for
your acked-by :)
	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=8d8a09b093d7073465c824f74caf315c073d3875

THanks,
Gao Xiang

> 
> regards,
> dan carpenter
>