linux-kernel - Re: [PATCH 2/2] Bluetooth: btrtl: Add firmware version print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5F48FCE3-E0AF-458D-8560-DF0B1DB10CC9@holtmann.org>
Date:   Fri, 30 Aug 2019 14:47:54 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Alex Lu <alex_lu@...lsil.com.cn>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        Max Chou <max.chou@...ltek.com>
Subject: Re: [PATCH 2/2] Bluetooth: btrtl: Add firmware version print

Hi Alex,

> This patch is used to print fw version for debug convenience
> 
> Signed-off-by: Alex Lu <alex_lu@...lsil.com.cn>
> ---
> drivers/bluetooth/btrtl.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index b7487ab99eed..7219eb98d02d 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -151,6 +151,8 @@ static const struct id_table ic_id_table[] = {
> 	  .cfg_name = "rtl_bt/rtl8822b_config" },
> 	};
> 
> +static struct sk_buff *btrtl_read_local_version(struct hci_dev *hdev);
> +
> static const struct id_table *btrtl_match_ic(u16 lmp_subver, u16 hci_rev,
> 					     u8 hci_ver, u8 hci_bus)
> {
> @@ -368,6 +370,8 @@ static int rtl_download_firmware(struct hci_dev *hdev,
> 	int frag_len = RTL_FRAG_LEN;
> 	int ret = 0;
> 	int i;
> +	struct sk_buff *skb;
> +	struct hci_rp_read_local_version *rp;
> 
> 	dl_cmd = kmalloc(sizeof(struct rtl_download_cmd), GFP_KERNEL);
> 	if (!dl_cmd)
> @@ -406,6 +410,18 @@ static int rtl_download_firmware(struct hci_dev *hdev,
> 		data += RTL_FRAG_LEN;
> 	}
> 
> +	skb = btrtl_read_local_version(hdev);
> +	if (IS_ERR(skb)) {
> +		ret = PTR_ERR(skb);
> +		rtl_dev_err(hdev, "read local version failed");
> +		goto out;
> +	}
> +
> +	rp = (struct hci_rp_read_local_version *)skb->data;
> +	rtl_dev_info(hdev, "rtl: fw version 0x%04x%04x",
> +		     __le16_to_cpu(rp->hci_rev), __le16_to_cpu(rp->lmp_subver));
> +	kfree_skb(skb);
> +

if you really want to do this, then please re-order the code so that no forward declaration is needed.

Regards

Marcel