linux-kernel - RE: [RFC v1 3/9] KVM: x86: Implement MSR_IA32_PEBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82D7661F83C1A047AF7DC287873BF1E1737F78B3@SHSMSX104.ccr.corp.intel.com>
Date:   Fri, 30 Aug 2019 00:22:08 +0000
From:   "Kang, Luwei" <luwei.kang@...el.com>
To:     Andi Kleen <ak@...ux.intel.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "Christopherson, Sean J" <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC v1 3/9] KVM: x86: Implement MSR_IA32_PEBS_ENABLE
 read/write emulation

> > +	case MSR_IA32_PEBS_ENABLE:
> > +		if (pmu->pebs_enable == data)
> > +			return 0;
> > +		if (!(data & pmu->pebs_enable_mask) &&
> > +		     (data & MSR_IA32_PEBS_OUTPUT_MASK) ==
> > +						MSR_IA32_PEBS_OUTPUT_PT)
> {
> > +			pebs_enable_changed(pmu, data);
> > +			return 0;
> > +		}
> 
> Need #GP for bad values

Yes, this function will return 1 if neither of above two conditions check are not true. And will inject a #GP to guest.

Thanks,
Luwei Kang