linux-kernel - Re: [PATCH] drm/amdgpu: Move null pointer dereference check

Open Source and information security mailing list archives

Message-ID: <CADnq5_PZ8cuQBVXAAH8mefHbnbK9M4QexbTN_9X-yyqdeaLcbw@mail.gmail.com>
Date:   Fri, 30 Aug 2019 11:09:43 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     Rex Zhu <rex.zhu@....com>, "Quan, Evan" <evan.quan@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Move null pointer dereference check

On Fri, Aug 30, 2019 at 8:43 AM Austin Kim <austindh.kim@...il.com> wrote:
>
> Null pointer dereference check should have been checked,
> ahead of below routine.
>         struct amdgpu_device *adev = hwmgr->adev;
>
> With this commit, it could avoid potential NULL dereference.
>
> Signed-off-by: Austin Kim <austindh.kim@...il.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> index 8189fe4..4728aa2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> @@ -722,16 +722,17 @@ static int smu8_request_smu_load_fw(struct pp_hwmgr *hwmgr)
>
>  static int smu8_start_smu(struct pp_hwmgr *hwmgr)
>  {
> -       struct amdgpu_device *adev = hwmgr->adev;
> +       struct amdgpu_device *adev;
>
>         uint32_t index = SMN_MP1_SRAM_START_ADDR +
>                          SMU8_FIRMWARE_HEADER_LOCATION +
>                          offsetof(struct SMU8_Firmware_Header, Version);
>
> -
>         if (hwmgr == NULL || hwmgr->device == NULL)
>                 return -EINVAL;
>
> +       adev = hwmgr->adev;
> +
>         cgs_write_register(hwmgr->device, mmMP0PUB_IND_INDEX, index);
>         hwmgr->smu_version = cgs_read_register(hwmgr->device, mmMP0PUB_IND_DATA);
>         pr_info("smu version %02d.%02d.%02d\n",
> --
> 2.6.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives