[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190831121751.GC1032@ninjato>
Date: Sat, 31 Aug 2019 14:17:51 +0200
From: Wolfram Sang <wsa@...-dreams.de>
To: Eugen.Hristev@...rochip.com
Cc: peda@...ntia.se, mark.rutland@....com,
Ludovic.Desroches@...rochip.com, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, pierre-yves.mordret@...com,
alexandre.belloni@...tlin.com, robh+dt@...nel.org,
Nicolas.Ferre@...rochip.com
Subject: Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering
> > + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node,
> > + "i2c-dig-filter");
> > +
>
> What do you think of the idea to introduce 'flags' to struct i2c_timings
> and parse the bindings in the core, too? Then you'd have sth like:
>
> if (t->flags & I2C_TIMINGS_ANALOG_FILTER)
>
> Would that be useful for you?
Forgot to say, we can also implement this incrementally to make sure
your patches land in 5.4 in case you are currently busy with sth else.
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists