linux-kernel - Re: [PATCH] tracing: silence noisy warnings about struct inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190831114856.26b0a1d7@oasis.local.home>
Date:   Sat, 31 Aug 2019 11:48:56 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [PATCH] tracing: silence noisy warnings about struct inode

On Sat, 31 Aug 2019 11:46:33 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 29 Aug 2019 14:34:18 -0700
> Randy Dunlap <rdunlap@...radead.org> wrote:
> 
> > From: Randy Dunlap <rdunlap@...radead.org>
> > 
> > Fix 30 warnings for missing "struct inode" declaration (like these) by
> > adding a forward reference for it.
> > These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
> >   CC      include/trace/events/iomap.h.s
> > 
> > ./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> > ./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Steven Rostedt <rostedt@...dmis.org>  

Hmm, I don't have this in my tree (I Cc'd Shuah, because I mistaken it as iommu.h.

Please send this to the appropriate maintainer that added this file.

-- Steve

> 
> Thanks!
> 
> -- Steve
> 
> > ---
> >  include/trace/events/iomap.h |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > --- linux-next-20190829.orig/include/trace/events/iomap.h
> > +++ linux-next-20190829/include/trace/events/iomap.h
> > @@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
> >  		  __entry->length)
> >  )
> >  
> > +struct inode;
> > +
> >  #define DEFINE_PAGE_EVENT(name)		\
> >  DEFINE_EVENT(iomap_page_class, name,	\
> >  	TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \  
>