linux-kernel - Re: [PATCH RESEND] arch/microblaze: add support for get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0711df8-50e1-c104-7603-929f8c4462cb@infradead.org>
Date:   Sun, 1 Sep 2019 07:55:08 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Leon Romanovsky <leonro@...lanox.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        "Steven J. Magnani" <steve@...idescorp.com>,
        Michal Simek <monstr@...str.eu>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH RESEND] arch/microblaze: add support for get_user() of
 size 8 bytes

On 8/31/19 11:49 PM, Leon Romanovsky wrote:
> On Sat, Aug 31, 2019 at 08:40:05PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> arch/microblaze/ is missing support for get_user() of size 8 bytes,
>> so add it by using __copy_from_user().
>>
>> Fixes these build errors:
>>    drivers/infiniband/core/uverbs_main.o: In function `ib_uverbs_write':
>>    drivers/infiniband/core/.tmp_gl_uverbs_main.o:(.text+0x13a4): undefined reference to `__user_bad'
>>    drivers/android/binder.o: In function `binder_thread_write':
>>    drivers/android/.tmp_gl_binder.o:(.text+0xda6c): undefined reference to `__user_bad'
>>    drivers/android/.tmp_gl_binder.o:(.text+0xda98): undefined reference to `__user_bad'
>>    drivers/android/.tmp_gl_binder.o:(.text+0xdf10): undefined reference to `__user_bad'
>>    drivers/android/.tmp_gl_binder.o:(.text+0xe498): undefined reference to `__user_bad'
>>    drivers/android/binder.o:drivers/android/.tmp_gl_binder.o:(.text+0xea78): more undefined references to `__user_bad' follow
>>
>> 'make allmodconfig' now builds successfully for arch/microblaze/.
>>
>> Fixes: 538722ca3b76 ("microblaze: fix get_user/put_user side-effects")
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Al Viro <viro@...iv.linux.org.uk>
>> Cc: Steven J. Magnani <steve@...idescorp.com>
>> Cc: Michal Simek <monstr@...str.eu>
>> Cc: Jason Gunthorpe <jgg@...lanox.com>
>> Cc: Leon Romanovsky <leonro@...lanox.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Doug Ledford <dledford@...hat.com>
>> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
>> ---
>> What is a reasonable path for having this patch merged?
>> Leon Romanovsky <leonro@...lanox.com> has tested it.
> 
> I tested it for compilation only, we (RDMA) don't work on
> arch/microblaze/ at all and care about kbuild failures only.

Hi Leon,
Since I modified the patch (about to send v3), I dropped your
Reviewed-by.

Thanks.

-- 
~Randy