linux-kernel - Re: [PATCH] autofs: remove redundant assignment to variable err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01ec26e2-6fd9-5ea0-4ef7-6a47e00bb2c5@wanadoo.fr>
Date:   Sun, 1 Sep 2019 17:30:37 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Colin King <colin.king@...onical.com>, Ian Kent <raven@...maw.net>,
        autofs@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] autofs: remove redundant assignment to variable err

Le 01/09/2019 à 17:22, Colin King a écrit :
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable err is being assigned a value that is never read and
> is being re-assigned a little later on. The assignment is redundant
> and hence can be removed.
>
> Addresses-Coverity: ("Ununsed value")

Ununsed?


> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   fs/autofs/dev-ioctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/autofs/dev-ioctl.c b/fs/autofs/dev-ioctl.c
> index a3cdb0036c5d..65d84b4d4464 100644
> --- a/fs/autofs/dev-ioctl.c
> +++ b/fs/autofs/dev-ioctl.c
> @@ -422,7 +422,7 @@ static int autofs_dev_ioctl_requester(struct file *fp,
>   	struct autofs_info *ino;
>   	struct path path;
>   	dev_t devid;
> -	int err = -ENOENT;
> +	int err;
>   
>   	/* param->path has been checked in validate_dev_ioctl() */
>