linux-kernel - Re: [PATCH 2/2] Fix a stack buffer overflow bug in check_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d80f1fba-8bf5-58e2-1801-5ac2308b5d4e@gmail.com>
Date:   Sun, 1 Sep 2019 15:47:31 -0400
From:   Hui Peng <benquike@...il.com>
To:     carnil@...ian.org
Cc:     stable@...r.kernel.org, mathias.payer@...elwelt.net,
        perex@...ex.cz, tiwai@...e.com, gregkh@...uxfoundation.org,
        wang6495@....edu, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Fix a stack buffer overflow bug in check_input_term


On 9/1/19 9:00 AM, Salvatore Bonaccorso wrote:
> Hi Hui,
>
> On Fri, Aug 30, 2019 at 05:47:29PM -0400, Hui Peng wrote:
>> `check_input_term` recursively calls itself with input from
>> device side (e.g., uac_input_terminal_descriptor.bCSourceID)
>> as argument (id). In `check_input_term`, if `check_input_term`
>> is called with the same `id` argument as the caller, it triggers
>> endless recursive call, resulting kernel space stack overflow.
>>
>> This patch fixes the bug by adding a bitmap to `struct mixer_build`
>> to keep track of the checked ids and stop the execution if some id
>> has been checked (similar to how parse_audio_unit handles unitid
>> argument).
>>
>> CVE: CVE-2018-15118
> Similar to the previous one, this should be CVE-2019-15118 as far I
> can tell.

Same here: CVE id updated.

Can you apply it to  v4.4.190 and v4.14.141?

Thanks.

>
> Regards,
> Salvatore

View attachment "0002-Fix-a-stack-buffer-overflow-bug-in-check_input_term.patch" of type "text/x-patch" (3426 bytes)