linux-kernel - Re: [PATCH -next RESEND] tracing: fix iomap.h build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190901211036.GC568270@magnolia>
Date:   Sun, 1 Sep 2019 14:10:36 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH -next RESEND] tracing: fix iomap.h build warnings

On Sat, Aug 31, 2019 at 01:25:37PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix 30 warnings for missing "struct inode" declaration (like these) by
> adding a forward reference for it.
> These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
>   CC      include/trace/events/iomap.h.s
> 
> ./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> ./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Darrick J. Wong <darrick.wong@...cle.com>
> ---
> Resend to correct maintainer(s).

Looks ok, will add it to my tree.  Thanks for the patch. :)

Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> 
>  include/trace/events/iomap.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20190829.orig/include/trace/events/iomap.h
> +++ linux-next-20190829/include/trace/events/iomap.h
> @@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
>  		  __entry->length)
>  )
>  
> +struct inode;
> +
>  #define DEFINE_PAGE_EVENT(name)		\
>  DEFINE_EVENT(iomap_page_class, name,	\
>  	TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
> 
>