linux-kernel - [PATCH] soc: qcom: ocmem: add missing includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190901213037.25889-1-masneyb@onstation.org>
Date:   Sun,  1 Sep 2019 17:30:37 -0400
From:   Brian Masney <masneyb@...tation.org>
To:     robdclark@...il.com, agross@...nel.org, bjorn.andersson@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild test robot <lkp@...el.com>
Subject: [PATCH] soc: qcom: ocmem: add missing includes

The kbuild bot reported the following compiler errors when compiling on
MIPS with CONFIG_QCOM_OCMEM disabled:

  In file included from <command-line>:0:0:
  >> include/soc/qcom/ocmem.h:43:49: warning: 'struct device' declared
     inside parameter list will not be visible outside of this
     definition or declaration
      static inline struct ocmem *of_get_ocmem(struct device *dev)
                                                      ^~~~~~
     include/soc/qcom/ocmem.h: In function 'of_get_ocmem':
  >> include/soc/qcom/ocmem.h:45:9: error: implicit declaration of
     function 'ERR_PTR' [-Werror=implicit-function-declaration]
       return ERR_PTR(-ENODEV);
              ^~~~~~~
  >> include/soc/qcom/ocmem.h:45:18: error: 'ENODEV' undeclared (first
     use in this function)
       return ERR_PTR(-ENODEV);

Add the proper includes to fix the compiler errors.

Signed-off-by: Brian Masney <masneyb@...tation.org>
Reported-by: kbuild test robot <lkp@...el.com>
---
My OCMEM series [1] hasn't landed upstream yet so let me know if you
want me to squash this into the existing patch set. I made this a
separate patch so that the Reported-by could be included. The kbuild
report is at [2].

[1] https://lore.kernel.org/lkml/20190823121637.5861-1-masneyb@onstation.org/
[2] https://lists.01.org/pipermail/kbuild-all/2019-August/063530.html

 include/soc/qcom/ocmem.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/soc/qcom/ocmem.h b/include/soc/qcom/ocmem.h
index a0ae336ba78b..02a8bc2677b1 100644
--- a/include/soc/qcom/ocmem.h
+++ b/include/soc/qcom/ocmem.h
@@ -9,6 +9,9 @@
  * Copyright (C) 2015 Red Hat. Author: Rob Clark <robdclark@...il.com>
  */
 
+#include <linux/device.h>
+#include <linux/err.h>
+
 #ifndef __OCMEM_H__
 #define __OCMEM_H__
 
-- 
2.21.0