[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190901102633.GB29681@amd>
Date: Sun, 1 Sep 2019 12:26:33 +0200
From: Pavel Machek <pavel@....cz>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>,
Dan Murphy <dmurphy@...com>, linux-leds@...r.kernel.org,
linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] leds: is31fl32xx: Use struct_size() helper
On Fri 2019-08-30 13:14:48, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct is31fl32xx_priv {
> ...
> struct is31fl32xx_led_data leds[0];
> };
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> So, replace the following function:
>
> static inline size_t sizeof_is31fl32xx_priv(int num_leds)
> {
> return sizeof(struct is31fl32xx_priv) +
> (sizeof(struct is31fl32xx_led_data) * num_leds);
> }
>
> with:
>
> struct_size(priv, leds, count)
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Acked-by: Pavel Machek <pavel@....cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists