linux-kernel - Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201909021438.ALbZpR85%lkp@intel.com>
Date:   Mon, 2 Sep 2019 14:35:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Peter Cai <peter@...eblog.net>
Cc:     kbuild-all@...org, Peter Cai <peter@...eblog.net>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Bastien Nocera <hadess@...ess.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-gpio@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2
 Max

Hi Peter,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Peter-Cai/gpio-acpi-add-quirk-to-override-GpioInt-polarity/20190902-004801
config: x86_64-fedora-25 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/input/touchscreen/goodix.c:168:18: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
      .driver_data = &gpio_mapping_force_irq_active_high
                     ^
   drivers/input/touchscreen/goodix.c: In function 'goodix_ts_probe':
>> drivers/input/touchscreen/goodix.c:830:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     dmi_match = dmi_first_match(need_gpio_mapping);
               ^

vim +/const +168 drivers/input/touchscreen/goodix.c

   156	
   157	/*
   158	 * Devices that need acpi_gpio_mapping to function correctly
   159	 */
   160	static const struct dmi_system_id need_gpio_mapping[] = {
   161	#if defined(CONFIG_DMI) && defined(CONFIG_X86)
   162		{
   163			.ident = "GPD P2 Max",
   164			.matches = {
   165				DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
   166				DMI_MATCH(DMI_PRODUCT_NAME, "P2 MAX")
   167			},
 > 168			.driver_data = &gpio_mapping_force_irq_active_high
   169		},
   170	#endif
   171		{}
   172	};
   173	#endif
   174	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50840 bytes)