linux-kernel - Re: [PATCH v3 01/10] software node: Get reference to parent swnode in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190902064605.GB5475@paasikivi.fi.intel.com>
Date:   Mon, 2 Sep 2019 09:46:05 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Petr Mladek <pmladek@...e.com>, linux-kernel@...r.kernel.org,
        rafael@...nel.org, linux-acpi@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3 01/10] software node: Get reference to parent swnode
 in get_parent op

On Fri, Aug 30, 2019 at 03:22:37PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 29, 2019 at 01:10:34PM +0300, Sakari Ailus wrote:
> > The software_node_get_parent() returned a pointer to the parent swnode,
> > but did not take a reference to it, leading the caller to put a reference
> > that was not taken. Take that reference now.
> > 
> 
> > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the
> > 		      firmware node framework")
> 
> I dunno if scripts parse the split line like above.
> 
> Nevertheless, for the code prospective looks good to me. Though you probably
> would like to Cc it to Heikki.

I will cc him for v4.

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com