linux-kernel - Re: [PATCH] mfd: ezx-pcap: replace mutex_lock with spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190902083805.GP4804@dell>
Date:   Mon, 2 Sep 2019 09:38:05 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: ezx-pcap: replace mutex_lock with spin_lock

On Tue, 13 Aug 2019, Fuqian Huang wrote:

> As mutex_lock might sleep.
> Function pcap_adc_irq is an interrupt handler.
> The use of mutex_lock in pcap_adc_irq may cause sleep
> in IRQ context.
> Replace mutex_lock with spin_lock to avoid this.

No one has complained explaining why this might be a bad idea and the
premise is sound enough.

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog