linux-kernel - Re: [PATCH] soc/tegra: fuse: Add clock error check in tegra_fuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95734aa4-c7cb-17a2-fa4c-416a5a40b3e6@nvidia.com>
Date:   Mon, 2 Sep 2019 11:45:01 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Nagarjuna Kristam <nkristam@...dia.com>,
        <thierry.reding@...il.com>, <kishon@...com>
CC:     <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc/tegra: fuse: Add clock error check in
 tegra_fuse_readl


On 28/08/2019 12:18, Nagarjuna Kristam wrote:
> Tegra fuse clock handle is retrieved in tegra_fuse_probe().
> tegra_fuse_readl() is exported symbol, which can be called from drivers
> at any time. tegra_fuse_readl() enables fuse clock and reads corresponding
> fuse register offset.
> 
> Calling tegra_fuse_readl() before tegra_fuse_probe(), will cause data
> abort. Add DEFER_PROBE error check for fuse clock in tegra_fuse_readl(),
> to avoid enabling of fuse clock, before clock is available.
> 
> Signed-off-by: Nagarjuna Kristam <nkristam@...dia.com>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
> index 3eb44e6..21b39b7 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra.c
> @@ -186,7 +186,7 @@ u32 __init tegra_fuse_read_early(unsigned int offset)
>  
>  int tegra_fuse_readl(unsigned long offset, u32 *value)
>  {
> -	if (!fuse->read)
> +	if (!fuse->read || (PTR_ERR(fuse->clk) == -EPROBE_DEFER))
>  		return -EPROBE_DEFER;

What about the case where fuse->clk is NULL or a different error value?

Jon

-- 
nvpublic