[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190902133520.evot6o35vr3bz5vq@linux.intel.com>
Date: Mon, 2 Sep 2019 16:35:20 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: linux-integrity@...r.kernel.org,
Alexey Klimov <aklimov@...hat.com>,
Peter Huewe <peterhuewe@....de>,
Jason Gunthorpe <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm: Remove duplicate code from caps_show() in
tpm-sysfs.c
On Fri, Aug 30, 2019 at 09:09:02AM -0700, Jerry Snitselaar wrote:
> On Thu Aug 29 19, Jarkko Sakkinen wrote:
> + /* TPM 1.1 */
> > + if (tpm1_getcap(chip, TPM_CAP_VERSION_1_1, &cap,
> > + "attempting to determine the 1.1 version",
> > + sizeof(cap.version1))) {
> > + version = &cap.version1;
:>
> Actually looking at this again, this seems wrong. The version
> assignment here should be below this if, or in an else block, yes?
Absolutely is in a wrong place.
I sent an updated patch:
https://patchwork.kernel.org/patch/11126741/
/Jarkko
Powered by blists - more mailing lists