linux-kernel - Re: [PATCH v2 5/9] s390: numa: check the node id consistently for s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201909021108.PNpZuBV8%lkp@intel.com>
Date:   Mon, 2 Sep 2019 12:05:19 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     kbuild-all@...org, catalin.marinas@....com, will@...nel.org,
        mingo@...hat.com, bp@...en8.de, rth@...ddle.net,
        ink@...assic.park.msu.ru, mattst88@...il.com,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        heiko.carstens@...ibm.com, gor@...ux.ibm.com,
        borntraeger@...ibm.com, ysato@...rs.sourceforge.jp,
        dalias@...c.org, davem@...emloft.net, ralf@...ux-mips.org,
        paul.burton@...s.com, jhogan@...nel.org, jiaxun.yang@...goat.com,
        chenhc@...ote.com, akpm@...ux-foundation.org, rppt@...ux.ibm.com,
        anshuman.khandual@....com, tglx@...utronix.de, cai@....pw,
        robin.murphy@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, hpa@...or.com, x86@...nel.org,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
        len.brown@...el.com, axboe@...nel.dk, dledford@...hat.com,
        jeffrey.t.kirsher@...el.com, linux-alpha@...r.kernel.org,
        nfont@...ux.vnet.ibm.com, naveen.n.rao@...ux.vnet.ibm.com,
        mwb@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org,
        linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
        sparclinux@...r.kernel.org, tbogendoerfer@...e.de,
        linux-mips@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH v2 5/9] s390: numa: check the node id consistently for
 s390

Hi Yunsheng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yunsheng-Lin/check-the-node-id-consistently-across-different-arches/20190901-143722
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/topology.h:35:0,
                    from include/linux/gfp.h:9,
                    from include/linux/mm.h:10,
                    from include/linux/kvm_host.h:14,
                    from arch/s390/kernel/asm-offsets.c:11:
   arch/s390/include/asm/topology.h: In function 'cpumask_of_node':
>> arch/s390/include/asm/topology.h:84:18: error: wrong type argument to unary exclamation mark
     if (node < 0 || !node_to_cpumask_map[node])
                     ^
   make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   43 real  4 user  3 sys  16.91% cpu 	make prepare

vim +84 arch/s390/include/asm/topology.h

    76	
    77	/* Returns a pointer to the cpumask of CPUs on node 'node'. */
    78	#define cpumask_of_node cpumask_of_node
    79	static inline const struct cpumask *cpumask_of_node(int node)
    80	{
    81		if (node >= nr_node_ids)
    82			return cpu_none_mask;
    83	
  > 84		if (node < 0 || !node_to_cpumask_map[node])
    85			return cpu_online_mask;
    86	
    87		return &node_to_cpumask_map[node];
    88	}
    89	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (55830 bytes)