linux-kernel - Re: linux-next: Tree for Sep 2 (exfat)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13e2db80-0c89-0f36-6876-f9639f0d30ab@infradead.org>
Date:   Mon, 2 Sep 2019 11:07:41 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Greg KH <greg@...ah.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Valdis Kletnieks <valdis.kletnieks@...edu>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: linux-next: Tree for Sep 2 (exfat)

On 9/2/19 10:46 AM, Greg KH wrote:
> On Mon, Sep 02, 2019 at 10:39:39AM -0700, Randy Dunlap wrote:
>> On 9/2/19 5:43 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> News: I will only be doing 2 more releases before I leave for Kernel
>>> Summit (there may be some reports on Thursday, but I doubt I will have
>>> time to finish the full release) and then no more until Sept 30.
>>>
>>> Changes since 20190830:
>>>
>>
>> Hi,
>> I am seeing lots of exfat build errors when CONFIG_BLOCK is not set/enabled.
>> Maybe its Kconfig should also say
>> 	depends on BLOCK
>> ?
> 
> Here's what I committed to my tree:
> 
> 
> From e2b880d3d1afaa5cad108c29be3e307b1917d195 Mon Sep 17 00:00:00 2001
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Date: Mon, 2 Sep 2019 19:45:06 +0200
> Subject: staging: exfat: make exfat depend on BLOCK
> 
> This should fix a build error in some configurations when CONFIG_BLOCK
> is not selected.  Also properly set the dependancy for no FAT support at
> the same time.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Valdis Kletnieks <valdis.kletnieks@...edu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

That works. Thanks.
Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> ---
>  drivers/staging/exfat/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
> index f52129c67f97..290dbfc7ace1 100644
> --- a/drivers/staging/exfat/Kconfig
> +++ b/drivers/staging/exfat/Kconfig
> @@ -1,11 +1,13 @@
>  config EXFAT_FS
>  	tristate "exFAT fs support"
> +	depends on BLOCK
>  	select NLS
>  	help
>  	  This adds support for the exFAT file system.
>  
>  config EXFAT_DONT_MOUNT_VFAT
>  	bool "Prohibit mounting of fat/vfat filesysems by exFAT"
> +	depends on EXFAT_FS
>  	default y
>  	help
>  	  By default, the exFAT driver will only mount exFAT filesystems, and refuse
> 


-- 
~Randy