linux-kernel - Re: [PATCH] power: supply: isp1704: remove redundant assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190902191347.thcbxwo2vm32hozz@earth.universe>
Date:   Mon, 2 Sep 2019 21:13:47 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Pali Rohár <pali.rohar@...il.com>,
        linux-pm@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: isp1704: remove redundant assignment to
 variable ret

Hi,

On Fri, Jul 05, 2019 at 10:36:12AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable ret is being assigned with a value that is never
> read and it is being updated later with a new value. The
> assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/isp1704_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c
> index b48cb7aba97b..4812ac1ff2df 100644
> --- a/drivers/power/supply/isp1704_charger.c
> +++ b/drivers/power/supply/isp1704_charger.c
> @@ -342,7 +342,7 @@ static inline int isp1704_test_ulpi(struct isp1704_charger *isp)
>  	int vendor;
>  	int product;
>  	int i;
> -	int ret = -ENODEV;
> +	int ret;
>  
>  	/* Test ULPI interface */
>  	ret = isp1704_write(isp, ULPI_SCRATCH, 0xaa);
> -- 
> 2.20.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)