linux-kernel - Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Sep 2019 23:19:58 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Wenwen Wang <wenwen@...uga.edu>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
        "open list:ACPI" <linux-acpi@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang <wenwen@...uga.edu> wrote:
>
> In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in
> acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However,
> it is not deallocated if acpi_pci_irq_valid() returns false, leading to a
> memory leak. To fix this issue, free 'entry' before returning 0.
>
> Fixes: e237a5518425 ("x86/ACPI/PCI: Recognize that Interrupt Line 255 means
> "not connected"")
>
> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>

Bjorn, any more comments?

> ---
>  drivers/acpi/pci_irq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index d2549ae..dea8a60 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -449,8 +449,10 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
>                  * No IRQ known to the ACPI subsystem - maybe the BIOS /
>                  * driver reported one, then use it. Exit in any case.
>                  */
> -               if (!acpi_pci_irq_valid(dev, pin))
> +               if (!acpi_pci_irq_valid(dev, pin)) {
> +                       kfree(entry);
>                         return 0;
> +               }
>
>                 if (acpi_isa_register_gsi(dev))
>                         dev_warn(&dev->dev, "PCI INT %c: no GSI\n",
> --
> 2.7.4
>