linux-kernel - Re: [PATCH] staging: exfat: cleanup braces for if/else statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190903173249.GL1131@ZenIV.linux.org.uk>
Date:   Tue, 3 Sep 2019 18:32:49 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Valentin Vidic <vvidic@...entin-vidic.from.hr>
Cc:     Valdis Kletnieks <valdis.kletnieks@...edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements

On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote:
> +			} else if (uni == 0xFFFF) {
>  				skip = TRUE;

While we are at it, could you get rid of that 'TRUE' macro?
Or added

#define THE_TRUTH_AND_THATS_CUTTIN_ME_OWN_THROAT true

if you want to properly emphasize it...