lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190903175610.GM1131@ZenIV.linux.org.uk>
Date:   Tue, 3 Sep 2019 18:56:10 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Qian Cai <cai@....pw>, linux-fsdevel@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: "fs/namei.c: keep track of nd->root refcount status" causes boot
 panic

On Tue, Sep 03, 2019 at 08:39:30AM -0700, Christoph Hellwig wrote:

> > There's much nastier situation than "new upstream kernel released,
> > need to rebuild" - it's bisect in mainline trying to locate something...
> 
> I really don't get the point.  And it's not like we've card about
> this anywhere else.  And jumping wildly around with the numeric values
> for constants will lead to bugs like the one you added and fixed again
> and again.

The thing is, there are several groups - it's not as if all additions
were guaranteed to be at the end.  So either we play with renumbering
again and again, or we are back to the square one...

Is there any common trick that would allow to verify the lack of duplicates
at the build time?

Or we can reorder the list by constant value, with no grouping visible
anywhere...

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ