linux-kernel - [PATCH] NFS: remove the redundant check when kfree an object in nfs_netns_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1567490688-17872-1-git-send-email-zhongjiang@huawei.com>
Date:   Tue, 3 Sep 2019 14:04:48 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <trond.myklebust@...merspace.com>, <anna.schumaker@...app.com>
CC:     <zhongjiang@...wei.com>, <linux-nfs@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] NFS: remove the redundant check when kfree an object in nfs_netns_client_release

kfree has taken the null check in account. hence it is unnecessary to add the
null check before kfree the object. Just remove it.

Signed-off-by: zhong jiang <zhongjiang@...wei.com>
---
 fs/nfs/sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c
index 4f3390b..c489496 100644
--- a/fs/nfs/sysfs.c
+++ b/fs/nfs/sysfs.c
@@ -121,8 +121,7 @@ static void nfs_netns_client_release(struct kobject *kobj)
 			struct nfs_netns_client,
 			kobject);
 
-	if (c->identifier)
-		kfree(c->identifier);
+	kfree(c->identifier);
 	kfree(c);
 }
 
-- 
1.7.12.4